Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for package access modifier to DependencyClient macro #209

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add support for package access modifier to DependencyClient macro #209

merged 1 commit into from
Apr 30, 2024

Conversation

ivanlisovyi
Copy link
Contributor

@ivanlisovyi ivanlisovyi commented Apr 30, 2024 •
edited
Loading

Context

Hey folks 👋 It seems like the @DependencyClient macro doesn't support the package access modifier when generating init's, which makes it harder to split the interface and implementation into two separate targets if the interface uses package access. This is because the generated init will have internal access.

Changes

  • Added package access modifier support to DependencyClientMacro
  • Added unit test to verify the change

mbrandonw
mbrandonw approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, and thanks for adding a test!

@mbrandonw mbrandonw merged commit 7b139d8 into pointfreeco:main Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrandonw mbrandonw mbrandonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanlisovyi @mbrandonw